Delete tests for .NET Framework Xsltc.exe tool

[danmoseley]

One of these tests is failing for me because the output of xsltc.exe is different. I briefly tried to figure out why but it's on .NET Framework so I didn't look very far. So I changed the baselines to be regular expressions, and added .* as needed to make it pass.

Also noted the first 4 lines of many of the baselines (the logo banner) is skipped, so I just blanked those lines out. I tried just removing them (and removing the matching offset of 4 in the test code) but it turns out some tests were mis-ported such that the 4 lines removed from the baseline file are the entire baseline file, and they pass because the result of the test is also empty. I don't plan to look at that now. Just wanted to make the tests pass more reliably.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

---

One of these tests is failing for me because the output of xsltc.exe is different. I briefly tried to figure out why but it's on .NET Framework so it's not very interesting. So I changed the baselines to be regular expressions, and added .* as needed to make it pass.

Also noted the first 4 lines of many of the baselines (the logo banner) is skipped, so I just blanked those lines out. I tried just removing them (and removing the matching offset of 4 in the test code) but it turns out some tests were mis-ported such that the 4 lines removed from the baseline file are the entire baseline file, and they pass because the result of the test is also empty. I don't plan to look at that now. Just wanted to make the tests pass more reliably.

Author:	danmoseley
Assignees:	danmoseley
Labels:	area-System.Xml
Milestone:	-

[jkotas]

I briefly tried to figure out why but it's on .NET Framework so I didn't look very far.

Why are we running tests for .NET Framework xsltc in this repo in the first place? Should all these tests be deleted instead?

[danmoseley]

Why are we running tests for .NET Framework xsltc in this repo in the first place? Should all these tests be deleted instead?

Somehow I failed to ask myself this question .. let me see how much I can delete.

[danmoseley]

Deleted all tests for xsltc.exe.

[jkotas]

You may be also able to delete the logic in XsltCommon.cs that tries to locale xsltc.exe tool in Windows SDK (

runtime/src/libraries/System.Private.Xml/tests/Xslt/XsltCompiler/XsltCommon.cs

Lines 334 to 380 in 57bfe47

	public static string SearchPath(string fileName)
	{
	var locations = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
	// 32 bit if on 64 bit Windows
	locations.Add(Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFilesX86), @"Microsoft SDKs\Windows"));
	// 32 bit if on 32 bit Windows, otherwise 64 bit
	locations.Add(Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.ProgramFiles), @"Microsoft SDKs\Windows"));
	// 64 bit if in 32 bit process on 64 bit Windows
	locations.Add(Path.Combine(Environment.GetEnvironmentVariable("ProgramW6432"), @"Microsoft SDKs\Windows"));
	var files = new List<string>();
	foreach (var location in locations)
	{
	if (Directory.Exists(location))
	files.AddRange(Directory.GetFiles(location, fileName, SearchOption.AllDirectories));
	}
	if (files.Count == 0)
	throw new FileNotFoundException(fileName);
	// Prefer newer versions, for stability
	files.Sort((left, right) =>
	{
	int comparison = Comparer<float>.Default.Compare(GetVersionFromSDKPath(left), GetVersionFromSDKPath(right));
	if (comparison == 0)
	comparison = string.Compare(left, right, StringComparison.OrdinalIgnoreCase);
	return comparison;
	});
	return files[files.Count - 1];
	}
	// Pull the version out of a path like "C:\Program Files (x86)\Microsoft SDKs\Windows\v7.0A\bin\xsltc.exe"
	private static float GetVersionFromSDKPath(string s)
	{
	Match match = Regex.Match(s, @"\\v(\d+\.\d+)\w?\\", RegexOptions.IgnoreCase);
	float val = 0;
	if (match.Success)
	float.TryParse(match.Groups[1].Value, out val);
	return val;
	}

and related code).

[danmoseley]

I already deleted that whole file.