Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 library tests: use full encoding map #71006

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

a74nh
Copy link
Contributor

@a74nh a74nh commented Jun 20, 2022

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479

Author: a74nh
Assignees: -
Labels:

area-System.Memory, community-contribution

Milestone: -

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @a74nh !

@adamsitnik adamsitnik merged commit 250e1b0 into dotnet:main Jun 22, 2022
@a74nh a74nh deleted the a74nh_base64full branch June 22, 2022 09:21
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Memory community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants