Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] [iOS][Android] Fix crash in Exception.CaptureDispatchState #71171

Merged
merged 4 commits into from
Jul 12, 2022

Commits on Jun 22, 2022

  1. [iOS][Android] Fix crash in Exception.CaptureDispatchState

    There is a crash in `Exception.CaptureDispatchState` when called from one thread at the same time another calls into `Exception.RestoreDispatchState`. The
    reason for the crash is due to the way we do not update `foreignExceptionFrames` in a thread-safe way.  `foreignExceptionFrames` is used in both methods and can crash when the size changes before the array is copied.
    
    The fix is to lock when reading from and writing to `foreignExceptionFrames`.
    
    Fixes #70081
    Steve Pfister authored and github-actions committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    cb9ab0f View commit details
    Browse the repository at this point in the history
  2. Lock all of CaptureDispatchState

    Steve Pfister authored and github-actions committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    cd92340 View commit details
    Browse the repository at this point in the history
  3. Marek's feedback

    Steve Pfister authored and github-actions committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    87a4c32 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Remove unnecessary field

    Steve Pfister committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    8f41e25 View commit details
    Browse the repository at this point in the history