Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NativeAOT] Enable dynamic linking of ucrt for release runtime #71182

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Jun 23, 2022

This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.

This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.
@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

This is enabled for release runtime only, same as how we do it for regular CoreCLR builds.

Author: jkotas
Assignees: jkotas
Labels:

area-Infrastructure-coreclr

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Jun 23, 2022

This makes AOT helloworld.exe about 200kB smaller.

Copy link
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas
Copy link
Member Author

jkotas commented Jun 23, 2022

Test failure is #70969

@jkotas jkotas merged commit 05ae801 into dotnet:main Jun 23, 2022
@jkotas jkotas deleted the dynamic-crt branch June 23, 2022 06:26
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants