Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TarFileMode with UnixFileMode #71222

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Replace TarFileMode with UnixFileMode #71222

merged 3 commits into from
Jun 23, 2022

Conversation

carlossanlop
Copy link
Member

Replaces the System.Formats.Tar.TarFileMode enum originally added in this PR: #67883
With the more general one, System.IO.UnixFileMode, which was freshly added in this PR: #69980

@carlossanlop carlossanlop added this to the 7.0.0 milestone Jun 23, 2022
@carlossanlop carlossanlop self-assigned this Jun 23, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces the System.Formats.Tar.TarFileMode enum originally added in this PR: #67883
With the more general one, System.IO.UnixFileMode, which was freshly added in this PR: #69980

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-System.IO
Milestone: 7.0.0

@carlossanlop
Copy link
Member Author

@baronfel FYI

@baronfel
Copy link
Member

Lovely, thank you for the ping. @rainersigwald this may be relevant.

eerhardt
eerhardt approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@carlossanlop
Copy link
Member Author

Test failures unrelated:

#70450 System.IO.Tests.SymbolicLink_Changed_Tests.FileSystemWatcher_SymbolicLink_IncludeSubdirectories_DoNotDereferenceChildLink
#71233 System.Net.Http.Functional.Tests - Assertion Failed - ClientCertificates. Expected enumerable cloned value.
#70969 The process cannot access the file 'D:\a_work\1\s\artifacts\log\Release\Microsoft.NET.HostModel.ComHost.Tests_net7.0_x64.log' because it is being used by another process.

@carlossanlop carlossanlop merged commit 970f58a into dotnet:main Jun 23, 2022
@carlossanlop carlossanlop deleted the ReplaceTarFileMode branch June 23, 2022 21:33
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@stephentoub stephentoub stephentoub approved these changes

@tmds tmds tmds approved these changes

@adamsitnik adamsitnik Awaiting requested review from adamsitnik

@bartonjs bartonjs Awaiting requested review from bartonjs

@jozkee jozkee Awaiting requested review from jozkee

Assignees

@carlossanlop carlossanlop

Labels
area-System.Formats.Tar new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@carlossanlop @baronfel @tmds @stephentoub @eerhardt