Add tests for contract customization per feedback in #70435 #71529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFixes remaining comments in #70435 - some were already addressed in #71449
|
krwq
commented
Jul 1, 2022
| @@ -287,70 +287,114 @@ public static void SetCustomConverterForAProperty() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public static void UntypedCreateObjectWithDefaults() | |||
There was a problem hiding this comment.
I merged Untyped and Typed test into one since it was mostly duplicated and therefore some code is removed here
eiriktsarpalis
approved these changes
Jul 1, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes remaining comments in #70435 - some were already addressed in #71449