Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GC] Handle objects from frozen segments in GCHeap::IsEphemeral #73110

Merged
merged 2 commits into from
Jul 31, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jul 30, 2022

Fixes an assert I hit in #49576 (comment)
Hopefully, helps NativeAOT #72645 (comment)

@ghost
Copy link

ghost commented Jul 30, 2022

Tagging subscribers to this area: @dotnet/gc
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes an assert I hit in #49576 (comment)
Hopefully, helps NativeAOT #72645 (comment)

Author: EgorBo
Assignees: -
Labels:

area-GC-coreclr

Milestone: -

@mangod9
Copy link
Member

mangod9 commented Jul 30, 2022

@EgorBo your change to allocate string literals on frozen segments is for 8, but looks like this fix is good to take for 7?

@EgorBo
Copy link
Member Author

EgorBo commented Jul 30, 2022

@EgorBo your change to allocate string literals on frozen segments is for 8, but looks like this fix is good to take for 7?

Right, that's why I extracted it from my PR. From my understanding we still want to enable GC Regions for NativeAOT in .NET 7.0

@MichalStrehovsky
Copy link
Member

There are also customers that use frozen objects with CoreCLR so this is needed everywhere. I'm going to merge and re-test with NativeAOT in #69108 to see if this was the last problem. Thank you!

@MichalStrehovsky MichalStrehovsky merged commit ec5e8b5 into dotnet:main Jul 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants