Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MonoAOTCompiler.cs: fix regression in caching, which breaks incremental #73427

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 5, 2022

.. builds.

#72394 disabled the cache always,
even when it was intended to be used. This reverses that change.

This shows up as a Wasm.Build.Tests failure:

Wasm.Build.NativeRebuild.Tests.SimpleSourceChangeRebuildTest.SimpleStringChangeInSource(buildArgs: BuildArgs { ProjectName = placeholder, Config = Release, AOT = True, ProjectFileContents = placeholder, ExtraBuildArgs =  }, nativeRelink: False, invariant: False, host: Chrome, id: "kfqswgdd.hbi") [FAIL]
      CompareStat failed:
      [Expected unchanged file: System.Private.CoreLib.dll.bc]
         old: FileStat { Exists = True, LastWriteTimeUtc = 8/4/2022 9:01:26 PM, Length = 16570448, FullPath = /datadisks/disk1/work/AEEC0971/w/AF8A095A/e/kfqswgdd.hbi/obj/Release/net7.0/browser-wasm/wasm/for-publish/System.Private.CoreLib.dll.bc }
         new: FileStat { Exists = True, LastWriteTimeUtc = 8/4/2022 9:02:39 PM, Length = 16570448, FullPath = /datadisks/disk1/work/AEEC0971/w/AF8A095A/e/kfqswgdd.hbi/obj/Release/net7.0/browser-wasm/wasm/for-publish/System.Private.CoreLib.dll.bc }

Fixes #73419

.. builds.

dotnet#72394 disabled the cache always,
even when it was intended to be used. This reverses that change.

Fixes dotnet#73419
@radical
Copy link
Member Author

radical commented Aug 5, 2022

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Aug 5, 2022

@steveisok @mdh1418 What was the problem being fixed with this change?

@radical
Copy link
Member Author

radical commented Aug 5, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdh1418
Copy link
Member

mdh1418 commented Aug 5, 2022

@steveisok @mdh1418 What was the problem being fixed with this change?

I don't recall there being a problem per se. I think there was a decision to disable caching for the NetTraceToMibc process, but missed this among the changes.

@radical
Copy link
Member Author

radical commented Aug 5, 2022

Debugger tests failure is #66024 .
@mdh1418 @steveisok Are the mobile ones known to fail?

@radical
Copy link
Member Author

radical commented Aug 5, 2022

Please merge if the failures look unrelated.

@radical
Copy link
Member Author

radical commented Aug 5, 2022

The other failures are #73343, #73453 . And some others are runtime tests with interpreter etc, but not related to this PR at all, AFAICS.

I'm going to merge this now, and unblock the CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] WBT test failure - SimpleSourceChangeRebuildTest.SimpleStringChangeInSource
2 participants