Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Generic attributes handling in CustomAttributeDecoder" #73671

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

buyaa-n
Copy link
Member

@buyaa-n buyaa-n commented Aug 10, 2022

Reverts #72561

The merge causing failures on rolling build and #73410

@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @dotnet/area-system-reflection-metadata
See info in area-owners.md if you want to be subscribed.

Issue Details

Reverts #72561

The merge causing failures on #73410

Author: buyaa-n
Assignees: -
Labels:

area-System.Reflection.Metadata

Milestone: -

@radical
Copy link
Member

radical commented Aug 10, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Aug 10, 2022

The failing wasm test will be fixed by #73537 and can be ignore here.

@radical
Copy link
Member

radical commented Aug 10, 2022

Can we merge this now?

@radical
Copy link
Member

radical commented Aug 10, 2022

I'm merging this now, to unblock CI.

@radical radical merged commit 7bc07c2 into main Aug 10, 2022
@buyaa-n buyaa-n deleted the revert-72561-gen-attributes branch August 10, 2022 15:26
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants