[workloads] Shorten the workload name even more #74150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
filipnavara
reviewed
Aug 18, 2022
| @@ -79,8 +79,8 @@ | |||
| <!-- Shorten package names to avoid long path issues in Visual Studio --> | |||
| <ItemGroup> | |||
| <!-- These need to be in order - matching rules will try in order. --> | |||
| <ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain.Manifest"> | |||
| <Replacement>MonoToolChainManifest</Replacement> | |||
| <ShortNames Include="Microsoft.NET.Workload.Mono.ToolChain."> | |||
There was a problem hiding this comment.
Too much shortening on this line? :-)
There was a problem hiding this comment.
nope, it matches from the start ;)
There was a problem hiding this comment.
So we'll end up with mono.manifest or something like that?
There was a problem hiding this comment.
BTW, I noticed there's already a VSIX package in VS with an ID called "Mono", so as long as we have another qualifier we should be okay.
There was a problem hiding this comment.
should end up as MonoManifest-7.0.100
hoyosjs
previously approved these changes
Aug 18, 2022
hoyosjs
dismissed
their stale review
Wait. Looks like it no longer has the Replacement metadata?
|
/backport to release/7.0-rc1 |
|
Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2885146213 |
radical
approved these changes
Aug 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.