[release/7.0-rc1] Disable Int128 use in by value ABI scenarios, and fix field layout behavior #74279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…n Unix platforms (64 bit) use 16 byte alignment - On Arm32 use 8 byte alignment matching the 128 byte vector type - On other Windows platforms the 128 bit integer type isn't defined by the C compiler, but match the behavior of other 128 bit types (16 byte alignment) Add tests to call down to native that should pass with these rules - Disable use of Int128 as p/invoke parameter passed by value
…hese types for parameter passing in R2R images
Co-authored-by: Jeremy Koritzinsky <[email protected]>
jkoritzinsky
approved these changes
Aug 19, 2022
jeffschwMSFT
approved these changes
Aug 19, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74123 to release/7.0-rc1
/cc @davidwrighton
Customer Impact
This fix adjust the alignment behavior of Int128 and UInt128 to match the native platform layout rules, and disables the ability to pass Int128 or structures containing Int128 by value across interop boundaries.
The combination of these two changes allows us to support customers who wish to interop with Int128 types without performing the extensive work necessary to make by-value passing of Int128 structures interoperate correctly with Native code.
If this fix is not taken for .NET 7, we will establish a new backwards compatibility problem where some customers may take a dependency on the incorrect layout behavior, thus preventing us from easily being able to fix this behavior in the future. We have not yet established a compatibility concern in this space as Int128 has not been part of a release which is under support.
Testing
Manual testing, as well as targeted test development.
Risk
Any and all changes to field layout and interop behavior are somewhat risky; however, this fix is scoped to impact Int128 scenarios only, which are extremely rare at this time, as .NET 7 is the first product to ship the Int128 type.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.