Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Change signature for diagnostic binaries #74323

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2022

Backport of #74322 to release/7.0-rc1

  • Add DAC signature infrastructure
  • Try using a .NET 6 SDK to enable signing

Use a signing infrastructure orthogonal to microbuild to use other certs for diagnostic binaries.

cc: @dotnet/dotnet-diag @leculver

@ghost
Copy link

ghost commented Aug 22, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74322 to release/7.0-rc1

/cc @hoyosjs

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Diagnostics-coreclr

Milestone: -

@hoyosjs
Copy link
Member

hoyosjs commented Aug 22, 2022

@github-actions github-actions bot force-pushed the backport/pr-74322-to-release/7.0-rc1 branch from b01bb0a to 2eaffd1 Compare August 22, 2022 05:26
@hoyosjs hoyosjs requested review from jkoritzinsky, mmitche and a team August 22, 2022 05:33
@github-actions github-actions bot force-pushed the backport/pr-74322-to-release/7.0-rc1 branch from 2eaffd1 to 484a52e Compare August 22, 2022 05:35
@github-actions github-actions bot force-pushed the backport/pr-74322-to-release/7.0-rc1 branch from 484a52e to d7fb63e Compare August 22, 2022 07:21
@carlossanlop
Copy link
Member

@jeffschwMSFT need an approval.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@carlossanlop
Copy link
Member

Thanks @jeffschwMSFT . The main PR is still open, so I'll wait for it to get signed-off and merged first.

@hoyosjs hoyosjs merged commit e69c9d0 into release/7.0-rc1 Aug 22, 2022
@hoyosjs hoyosjs deleted the backport/pr-74322-to-release/7.0-rc1 branch August 22, 2022 21:19
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants