[release/7.0] Fix FormattingHelpers.CountDigits(UInt128) and add more tests for Int128/UInt128.ToString #74536
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…128/UInt128.ToString
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
tannergooding
added
the
Servicing-consider
|
Approved -- customer reported defective/incomplete 7.0 scenario, and risk of change is limited to the new feature. Also, it's memory corruption |
danmoseley
removed
the
Servicing-consider
|
I'm not sure whether were using the labels or not right now -- the others apparently aren't .. removing labels, but it's approved |
|
Tagging subscribers to this area: @dotnet/area-system-runtime Issue DetailsBackport of #74501 to release/7.0 /cc @tannergooding Customer ImpactDevelopers will not be able to successfully format certain Int128 or UInt128 strings TestingAdditional tests were added covering the explicitly flagged scenarios as well as other boundary values to validate correct formatting. RiskMinimal, there are now tests explicitly covering each of the possible CountDigits code paths. This code path is only used by Int128/UInt128 which are new types in .NET 7
|
|
Approved and signed off. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #74501 to release/7.0
/cc @tannergooding
Customer Impact
Developers will not be able to successfully format certain Int128 or UInt128 strings
Testing
Additional tests were added covering the explicitly flagged scenarios as well as other boundary values to validate correct formatting.
Risk
Minimal, there are now tests explicitly covering each of the possible CountDigits code paths. This code path is only used by Int128/UInt128 which are new types in .NET 7