Fold field offsets into array addresses #74719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsThat is: We're expecting some positive diffs.
|
This allows us to re-associate the expessions such that
the outer field offset additions can get folded into:
ADD
ARR_ADDR T[]
ADD
LCL_VAR array
CNS_INT 40
8
=>
ARR_ADDR T[] [+8]
ADD
ADD
LCL_VAR array
CNS_INT 40
8
=>
ARR_ADDR T[] [+8]
ADD
LCL_VAR array
CNS_INT 48
No longer necessary.
SingleAccretion
force-pushed
the
Arr-Addr-Folding
branch
from
1411751
to
cb4065e
Compare
This was referenced Aug 29, 2022
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is:
We're expecting some positive diffs.
This should also help get rid of regressions seen over at #72725.