Fix incorrect "illegal XML comment chars" check & add regression tests #74787
Conversation
Also adds regression tests
|
Tagging subscribers to this area: @dotnet/area-system-xml Issue DetailsIn PR #69038, we accidentally changed an "ends with" check to a "starts with" check. This fixes that error and improves our regression test coverage. From scanning through the original PR, there were two locations total where it appears we introduced errors into the logic. #71752 (already in the 7.0 RC1 branch) addressed one of them; this PR addresses the remaining location. Since this is a regression from 6.0 and affects customer scenarios, I'll kick off the backporting process once this PR is merged. Resolves #74752.
|
|
Side observation, not really realted to this PR: the workhorse method behind |
| @@ -7,5 +7,6 @@ | |||
| <Compile Include="WriteWithEncoding.cs" /> | |||
| <Compile Include="WriteWithEncodingWithFallback.cs" /> | |||
| <Compile Include="WriteWithInvalidSurrogate.cs" /> | |||
| <Compile Include="XmlTextWriterTests.cs" /> | |||
There was a problem hiding this comment.
this caught my eye :/ .. as far as I can see our test coverage of XmlTextWriter is minimal. Our tests test various other *Xml*Writers. XmlWriter.Create() doesn't seem to create one either. Not an urgent problem, but I suppose it led to this bug.
Was #69038 backported to 6? |
@eiriktsarpalis No, this only affects 7.0. |
|
Per suggestion at #74787 (comment), will rerun the tests tomorrow morning against netfx481 just to validate the behavior. Hold off merging until then. |
GrabYourPitchforks
added
the
NO-MERGE
Seems like a reasonable API proposal.. |
|
Tested against 4.8, 3.1, 6.0, and [unpatched] 7.0. Tests succeed on all platforms except the platform where the regression was introduced. So I think we're good for merge!
|
|
Test failure is tracked by #74795. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2957973010 |
eiriktsarpalis
removed
the
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
In PR #69038, we accidentally changed an "ends with" check to a "starts with" check. This fixes that error and improves our regression test coverage. From scanning through the original PR, there were two locations total where it appears we introduced errors into the logic. #71752 (already in the 7.0 RC1 branch) addressed one of them; this PR addresses the remaining location.
Since this is a regression from 6.0 and affects customer scenarios, I'll kick off the backporting process once this PR is merged.
Resolves #74752.