Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Initial provisions for semantic Crossgen2 PDB validation #75172

Closed
wants to merge 7 commits into from

Commits on Sep 7, 2022

  1. Initial provisions for semantic Crossgen2 PDB validation

    This Quality Week work item is motivated by my findings from a few
    months back that Crossgen2 PDB generator had been producing bogus
    symbol files for almost half a year due to a trivial bug and no
    testing in place was able to catch that. This change adds initial
    provisions for semantic PDB validation.
    
    In this initial commit I'm adding a new managed app PdbChecker
    that uses the DIA library to read a given PDB and optionally check
    it for the presence of given symbols. In parallel I'm making test
    infra changes that enable selective PDB validation support in
    individual tests including checks for the presence of expected
    symbols.
    
    This change by itself introduces rudimentary PR / CI validation of
    PDB files produced by Crossgen2. As next step I plan to introduce
    additional provisions for running this logic for all tests to be
    added to one of the Crossgen2-specific pipelines, and validation
    of PDBs produced during compilation of the framework assemblies.
    
    Thanks
    
    Tomas
    trylek committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    176296c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ec1cf32 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    901c3f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Configuration menu
    Copy the full SHA
    0e4f09a View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Retry building against Dia2Lib

    trylek committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    4c97416 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Configuration menu
    Copy the full SHA
    1f1a570 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d22eaa5 View commit details
    Browse the repository at this point in the history