-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workloads] Add new workloads for net8.0 #75200
Conversation
Net8 workloads still won't really work in wbt until there is a proper net8 sdk without another hack |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-wasm-perf |
Azure Pipelines successfully started running 1 pipeline(s). |
…, and need net7 worklaod
…dotnet#75274)" This reverts commit fce39ad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the autoimport stuff can't work this way
src/mono/nuget/Microsoft.NET.Runtime.WebAssembly.Sdk/Sdk/AutoImport.props
Outdated
Show resolved
Hide resolved
src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Manifest/WorkloadManifest.targets.in
Outdated
Show resolved
Hide resolved
… 7.0 branch gets the fix for forwardConsole arg being renamed
This reverts commit 1b05102.
- this was failing because the test added reference to a function `withExitOnUnhandledError()` to `main.js`, which is available only in 8.0 . But the tests are still running with wasm-tools-net7, and tfm=net7.0 .
/azp run runtime-wasm-perf |
Azure Pipelines successfully started running 1 pipeline(s). |
This was generated part of some nugets to fix file permissions because it wasn't supported by nuget. But that is fixed now, stop generating the file, and remove the corresponding tests.
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
|
All the failures are unrelated. Merging this, which will also unblock |
Backport the workload changes from net7 but and a versionless manifest that represents the netappcurrent so that version bumps will require fewer immediate changes in net9.0
Wasm.Build.Tests
installswasm-tools
, andwasm-tools-net7
wasm-tools
, andwasm-tools-net7
for running, with projects built fornet7.0
net6.0
workload install is attempted, but fails because the6.0.10
package isn't on public feeds yet