Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] Add new workloads for net8.0 #75200

Merged
merged 37 commits into from
Sep 10, 2022
Merged

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 7, 2022

Backport the workload changes from net7 but and a versionless manifest that represents the netappcurrent so that version bumps will require fewer immediate changes in net9.0

  • Wasm.Build.Tests installs wasm-tools, and wasm-tools-net7
  • and uses a sdk with both wasm-tools, and wasm-tools-net7 for running, with projects built for net7.0
  • net6.0 workload install is attempted, but fails because the 6.0.10 package isn't on public feeds yet

@ghost ghost assigned lewing Sep 7, 2022
@lewing lewing changed the title Fix workloads 8 [workloads] Fix workloads in net8.0 Sep 7, 2022
@lewing
Copy link
Member Author

lewing commented Sep 7, 2022

Net8 workloads still won't really work in wbt until there is a proper net8 sdk without another hack

@lewing lewing changed the title [workloads] Fix workloads in net8.0 [workloads] Add new workloads for net8.0 Sep 7, 2022
@radical
Copy link
Member

radical commented Sep 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 8, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member Author

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the autoimport stuff can't work this way

- this was failing because the test added reference to a function
`withExitOnUnhandledError()` to `main.js`, which is available only in
8.0 . But the tests are still running with wasm-tools-net7, and
tfm=net7.0 .
@radical
Copy link
Member

radical commented Sep 9, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was generated part of some nugets to fix file permissions because
it wasn't supported by nuget. But that is fixed now, stop generating the
file, and remove the corresponding tests.
@radical
Copy link
Member

radical commented Sep 10, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 10, 2022

Installer Build and Test coreclr OSX_arm64 Release - failed due to network issues.
libraries Test Run release coreclr Linux x64 Debug is #75378 .
Libraries Test Run release mono Linux arm64 Debug - timed out, and it unrelated to this PR.
mono llvmaot Pri0 Runtime Tests Run Linux x64 release - #75391

@radical
Copy link
Member

radical commented Sep 10, 2022

All the failures are unrelated. Merging this, which will also unblock main.

@radical radical merged commit d6a4f7a into dotnet:main Sep 10, 2022
@lewing lewing deleted the fix-workloads-8 branch September 10, 2022 17:06
@ghost ghost locked as resolved and limited conversation to collaborators Oct 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants