Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Bump the macOS image to one that isn't EOL yet #75294

Merged
merged 2 commits into from
Sep 13, 2022
Merged

[release/6.0] Bump the macOS image to one that isn't EOL yet #75294

merged 2 commits into from
Sep 13, 2022

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 8, 2022

No description provided.

@ghost ghost assigned lewing Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: lewing
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@steveisok steveisok mentioned this pull request Sep 8, 2022
Closed
4 tasks
@lewing lewing requested a review from hoyosjs September 8, 2022 18:52
@lewing lewing mentioned this pull request Sep 8, 2022
Merged
@lewing
Copy link
Member Author

lewing commented Sep 8, 2022

needs #68847

@lewing lewing closed this Sep 12, 2022
@lewing lewing reopened this Sep 12, 2022
@carlossanlop
Copy link
Member

needs #68847

Considering #68847 (comment) failed to backport, what's the plan with this?

@steveisok
Copy link
Member

needs #68847

Considering #68847 (comment) failed to backport, what's the plan with this?

Let me see what I can do to resolve this.

@steveisok
Copy link
Member

@tarekgh since the ICU changes needed to be manually integrated, can you please sanity check me?

tarekgh
tarekgh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes LGTM.

I hope this change will stay for some time before releasing it to reduce the risk in the servicing release. I am not seeing any problem though.

@steveisok steveisok added the Servicing-consider Issue for next servicing release review label Sep 13, 2022
@steveisok
Copy link
Member

Since this contains some ICU changes, I think having tactics approve / be aware is the right way to go.

@lewing lewing mentioned this pull request Sep 13, 2022
Closed
@ayakael ayakael mentioned this pull request Sep 13, 2022
Closed
9 tasks
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 13, 2022
@rbhanda rbhanda added this to the 6.0.10 milestone Sep 13, 2022
@carlossanlop
Copy link
Member

Approved, signed off, CI is green. Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit bc65e68 into dotnet:release/6.0 Sep 13, 2022
@jkotas jkotas mentioned this pull request Sep 14, 2022
Merged
@lewing lewing deleted the bump-macos-release-6-0 branch September 23, 2022 23:08
@tarekgh tarekgh mentioned this pull request Oct 17, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@steveisok steveisok steveisok approved these changes

@hoyosjs hoyosjs Awaiting requested review from hoyosjs

Assignees

@lewing lewing

Labels
area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
6.0.10
Development

Successfully merging this pull request may close these issues.
5 participants
@lewing @carlossanlop @steveisok @tarekgh @rbhanda