Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/6.0] Add reference assembly for System.Private.CoreLib.dll #75311

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[release/6.0] Add reference assembly for System.Private.CoreLib.dll #75311

merged 1 commit into from
Sep 13, 2022

Commits on Sep 8, 2022

  1. Add reference assembly for System.Private.CoreLib.dll 

    We now compile against the reference assembly in all places where we were compiling against the mono/coreclr System.Private.CoreLib.dll implementation assembly before.

The new reference assembly consumes sources from the existing contracts to avoid checking in a generated version of SPC.dll (this would add ~20k lines of .cs which is mostly duplicated with System.Runtime.cs)

Since a few contracts have only partially moved types to SPC we wrap contract types with `#if !BUILDING_CORELIB_REFERENCE` so we can hide them when compiling the SPC reference assembly.
    @akoeplinger
    akoeplinger committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    c3ff69a View commit details
    Browse the repository at this point in the history