Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils #75525

Merged
merged 2 commits into from
Sep 14, 2022
Merged

[release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils #75525

merged 2 commits into from
Sep 14, 2022

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 13, 2022 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/llvm-project

  • Subscription: dc7edec6-2e27-40ef-139c-08da7ef5fa55
  • Build: 20220912.2
  • Date Produced: September 12, 2022 5:13:11 PM UTC
  • Commit: 5ea5dce046297788f942ab2bb5b1510035efb2ff
  • Branch: refs/heads/dotnet/release/7.0

From https://github.com/dotnet/hotreload-utils

  • Subscription: f62fea6e-d057-4466-663e-08da7ef6346a
  • Build: 20220912.2
  • Date Produced: September 12, 2022 2:15:27 PM UTC
  • Commit: 9adb819d35d6e2788b6772d579d6ca1e9ef68765
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/llvm-project build…
9687de6 
… 20220912.2

runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-arm64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.linux-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.osx.10.12-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Sdk , runtime.win-x64.Microsoft.NETCore.Runtime.Mono.LLVM.Tools
 From Version 11.1.0-alpha.1.22459.1 -> To Version 11.1.0-alpha.1.22462.2
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow label Sep 13, 2022
@dotnet-maestro
Update dependencies from https://github.com/dotnet/hotreload-utils bu…
b678585 
…ild 20220912.2

Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
 From Version 1.1.0-alpha.0.22456.2 -> To Version 1.1.0-alpha.0.22462.2
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils Sep 13, 2022
lambdageek
lambdageek approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little bit surprised there's codeflow from hotreload-utils. we don't have a 7.0 branch in that repo, just main. (also it's just a testing component).

@lewing
Copy link
Member

lewing commented Sep 14, 2022 •
edited
Loading

I'm a little bit surprised there's codeflow from hotreload-utils. we don't have a 7.0 branch in that repo, just main. (also it's just a testing component).

there is a darc subscription in all the branches and arcade/roslyn changes keep producing packages

@carlossanlop
Copy link
Member

I'm a little bit surprised there's codeflow from hotreload-utils. we don't have a 7.0 branch in that repo, just main. (also it's just a testing component).

there is a darc subscription in all the branches and arcade/roslyn changes keep producing packages

@lewing so no problems or concerns with this dependency update? Is this good to merge?

BTW the test failure was the good ol' false positive we keep seeing in System.Net.Http.Functional.Tests.

=== TEST EXECUTION SUMMARY ===
   System.Net.Http.Functional.Tests  Total: 4168, Errors: 0, Failed: 0, Skipped: 19, Time: 127.590s
/root/helix/work/workitem/e
----- end Tue Sep 13 17:28:54 UTC 2022 ----- exit code 0 ----------------------------------------------------------

@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project Sep 14, 2022
@dotnet-maestro dotnet-maestro bot changed the title [release/7.0] Update dependencies from dotnet/hotreload-utils dotnet/llvm-project [release/7.0] Update dependencies from dotnet/llvm-project dotnet/hotreload-utils Sep 14, 2022
@lambdageek
Copy link
Member

so no problems or concerns with this dependency update? Is this good to merge?

Not sure what Larry thinks, but I think it's ok for now. Once 7.0 is RTM we should probably turn off the subscription from hotreload-utils to runtime release/7.0. (the hotreload-utils package produces a nuget that is used for hot reload CI tests in runtime - it doesn't add any shipping artifacts). At that point we're not likely to make any changes ot the 7.0 hot reload tests that would require a newer hotreload-utils.

@carlossanlop
Copy link
Member

:shipit:

@carlossanlop carlossanlop merged commit a6a2c38 into release/7.0 Sep 14, 2022
@carlossanlop carlossanlop deleted the darc-release/7.0-2cf5f7d9-6065-4961-8095-b6f870d56dd1 branch September 14, 2022 17:56
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@lewing lewing lewing approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lewing @carlossanlop @lambdageek