[release/7.0] JIT: fix incorrect scale in genCreateAddrMode + no-opt #75560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #75433 to release/7.0 /cc @EgorBo Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
|
@kunalspathak, please review this 7.0 backporting PR. |
|
cc @jeffschwMSFT for 7.0 backport. |
jeffschwMSFT
approved these changes
Sep 13, 2022
AndyAyersMS
approved these changes
Sep 13, 2022
kunalspathak
approved these changes
Sep 14, 2022
|
Main issue has been merged. This has been approved, signed off, and CI is green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #75433 to release/7.0
/cc @EgorBo
Customer Impact
Fixes a bug where for unoptimized code JIT emits a memory load for e.g. an array with an incorrect offset, e.g.:
array[index * 0 + 1]ends up accessingarray[index + 1]instead ofarray[1]- it's not possible to reproduce this in pure C# because Roslyn foldsx * 0to0even in Debug but it can be reproduced with C++/CLI (initially was reported as https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1595540?src=WorkItemMention&src-action=artifact_link) or custom IL.Testing
Test is added, no impact on existing C# code
Risk
Low