Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] [wasm] Don't use MS.Build.NoTargets SDK for runtime tests #76107

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 23, 2022

Backport of #75939 to release/7.0

/cc @radical

Customer Impact

CI fix to stop restoring NoTargets so that msbuild can't possibly fail in that step #75391

Testing

CI issue so tested in this PR and other CI runs

Risk

trifling

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

This will also avoid intermittent failures like #75391
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 23, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75939 to release/7.0

/cc @radical

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure

Milestone: -

@lewing lewing added the arch-wasm WebAssembly architecture label Sep 24, 2022
@ghost
Copy link

ghost commented Sep 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #75939 to release/7.0

/cc @radical

Customer Impact

CI fix to stop restoring NoTargets so that msbuild can't possibly fail in that step #75391

Testing

CI issue so tested in this PR and other CI runs

Risk

trifling

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-Infrastructure

Milestone: -

@lewing
Copy link
Member

lewing commented Sep 24, 2022

the coreclr failures cannot be related to this wasm only change :|

@lewing lewing merged commit 5429eb1 into release/7.0 Sep 24, 2022
@lewing lewing deleted the backport/pr-75939-to-release/7.0 branch September 24, 2022 03:54
@ghost ghost locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants