Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC: Fix CheckPromoted for frozen objects #76251

Merged
merged 18 commits into from
Oct 4, 2022
Merged

Commits on Sep 27, 2022

  1. CheckPromoted used to mark weakref to a frozen object in SyncBlock as…

    … unreachable because it was not promoted
    EgorBo committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    821246a View commit details
    Browse the repository at this point in the history
  2. Move check to gc.cpp

    EgorBo committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    77d91a7 View commit details
    Browse the repository at this point in the history
  3. clean up

    EgorBo committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    7d88147 View commit details
    Browse the repository at this point in the history
  4. Use safer IsInFrozenSegment

    EgorBo committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    d359490 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    86dc10c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c50eb34 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Configuration menu
    Copy the full SHA
    555e1dd View commit details
    Browse the repository at this point in the history
  2. Add test

    EgorBo committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    40f58e0 View commit details
    Browse the repository at this point in the history
  3. clean up

    EgorBo committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    dc66006 View commit details
    Browse the repository at this point in the history
  4. Update Runtime_76219.cs

    EgorBo authored Sep 28, 2022
    Configuration menu
    Copy the full SHA
    42b56d2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    633e52a View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    5de363a View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. + actually setting the mark array bits for ro segments

    + moved where we are calling mark_ro_segments to the right places -
      for BGC this needs to be in the 2nd non concurrent phase)
      for blocking GCs I just moved it to a more appropriate place
    + for full blocking GCs it's not enough to do mark_ro_segments when gen start seg is not ephemeral.
    when we are doing a gen2 GC, even if we have acquired a new seg for that heap, we still need
    to mark all in range ro segs because our logic in IsPromoted expects when there's in range ro
    segs we need the mark bit to tell us these ro objects are marked.
    + got rid of some unnecessary checks
    
    Note that I do make the assumption that ro segs are always threaded at the beginning of gen2. We
    actually always thread these into heap 0's gen2 seg list but I can see a chance of that changing,
    if we want a better balancing of the mark_ro_segments work.
    Maoni0 committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d7caee3 View commit details
    Browse the repository at this point in the history
  2. Fix build breaks

    jkotas committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3447a2f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fb62389 View commit details
    Browse the repository at this point in the history
  4. fix stupid type, although, this path is never taken (only if FOH is d…

    …isabled via env.var but we'll get rid of that soon)
    EgorBo committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    a41ec83 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dae518f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. Enable GC Regions back

    EgorBo authored Oct 4, 2022
    Configuration menu
    Copy the full SHA
    9d4cbd2 View commit details
    Browse the repository at this point in the history