-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize test script naming to CLRTestBa{tc,s}hP{re,ost}Commands #76483
Merged
Merged
Changes from 26 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ee6de1a
Extract environment variable changes from test/filecheck
markples da94e49
a few more
markples df75a0e
more tests
markples f28c714
more tests
markples 51c2f3b
more tests
markples 59e9423
more tests
markples f6b9454
more tests
markples 943894b
more tests
markples dd30ce7
More tests
markples 26b596b
Bash fix
markples 24e297a
Manually [re]move comments, remove empty PropertyGroups
markples 16a48dc
Standardize on CLRTestBatchPreCommands and CLRTestBa{s,tc}hPostCommands
markples dbb82fb
Start converting CLRTestBashPreCommands
markples 70795e3
Convert RunWithGcStress to new envvar format
markples 031d597
Standardize on CLRTestBashPreCommands
markples 1412f34
Merge branch 'main' into test/naming
markples 3278bfc
Convert more environment variables
markples 5b59f92
put that quote back
markples 9099d27
Merge remote-tracking branch 'dotnet/main' into test/naming
markples d78e100
finish merge
markples aedc682
Merge remote-tracking branch 'dotnet/main' into test/naming
markples 8bd594c
Env vars in Runtime_75607
markples f67b54f
Restore destructive overwrite of precommands for wasm
markples 9945798
Undo Runtime_76218 change
markples ab78cba
Merge remote-tracking branch 'dotnet/main' into test/naming
markples c6b99ea
Convert names in two newer tests
markples edb6fd5
typo
markples dc271bc
Merge remote-tracking branch 'dotnet/main' into HEAD
markples 7b2b8bd
Also move new InstrumentedTiers to env var syntax
markples 06a7059
back to DOTNET_
markples File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you revert this from DOTNET_ to COMPlus_?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. I think what happened is (1) I started this change before the COMPlus_ rename, (2) it has been open a long time due to it not being my highest priority and test failures (some real, some not), (3) I missed it when I merged the rename, and (4) my re-checks for envvar, complus_, precommands were limited to *proj and missed this file. I checked again and also found some envvars in the new InstrumentedTiers.csproj (which I have less excuse for since I had already renamed the PreCommands variable in it...)