[release/7.0] Fix regression in JsonIgnoreAttribute handling of unsupported property types
#76869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsBackport of #76828 to release/7.0 Customer ImpactWe received a couple of customer reports that TestingAdded regression testing for the identified scenarios. RiskLow. Makes a minor change in product code so that a lazy loading mechanism already employed in source generated metadata is also applied to reflection derived metadata.
|
eiriktsarpalis
requested review from
krwq and
layomia
and removed request for
krwq
eiriktsarpalis
added
the
Servicing-consider
eiriktsarpalis
changed the title
JsonIgnoreAttribute handling of unsupported property types
krwq
reviewed
Oct 11, 2022
...es/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 11, 2022
...es/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 11, 2022
...es/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 11, 2022
...es/System.Text.Json/src/System/Text/Json/Serialization/Metadata/ReflectionJsonTypeInfoOfT.cs
Show resolved
Hide resolved
Closed
2 tasks
rbhanda
added
Servicing-approved
jeffhandley
approved these changes
Oct 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #76828 to release/7.0
Customer Impact
We received a couple of customer reports that
JsonIgnoreAttributehandling when applied to unsupported property types has regressed in .NET 7. Even though there are workarounds for the issue, these are generally unintuitive to users and require code modifications, which might inhibit migration of existing applications to .NET 7.Testing
Added regression testing for the identified scenarios.
Risk
Low. Makes a minor change in product code so that a lazy loading mechanism already employed in source generated metadata is also applied to reflection derived metadata.