Consecutive registers #77072
Closed
Consecutive registers #77072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add interval_2 class and use it throughout. This is a zero diff change.
This change helps in consolidating various methods to take `Referenceable*` as parameter instead of child classes `Interval*` or `RegRecord*`. With that, it will be possible to have a common logic in those methods that will check how many registers to process based upon either the information of `regCount` in `Interval` class or `regCount` in `RegRecord` class. Also splitted updateAssignedInterval() in `updateAssignedInterval()` that operates when `interval != nullptr` and `clearAssignedInterval()`.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsJust a draft to see if things so far are smooth.
|
2 tasks
…te in batch. At some places, we do things at individual register level. They used to take `RegRecord*` and we would operate on the register. They will never have type other than `TYP_INT` / `TYP_FLOAT`. However, the `Interval` can have a `registerType` that represents the type of the variable it represents. So we separate the methods that operate on registers in the ones that does things on single register (and hence takes `RegRecord*`) and the ones that can operate on more than one registers (and hence takes `Interval*`).
Also add few methods that just updates the updateNextIntervalRef(), updateSpillCost() as well as methods to get the firstRegister() of the series.
In earlier commits, I consolidated these 2 methods taking `Referenceable*` but proper way to do is split in overloaded method. One set takes `Interval*` and operates on the type of `Interval*` while the other set operates at individual `register` level.
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
1. Added template for unassignPhysReg<bool consecutiveRegisters>. Places from when consecutiveRegisters=true, that means unassignPhysReg() should reset the series of registers. If consecutiveRegisters=false, it will just operate on single register. 2. Refactored lot of methods around `clearAssignedIntervalForConflict()`, `restorePreviousInterval()`, unassignPhysReg.
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a draft to see if things so far are smooth.