Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release/7.0] Issue ICorProfiler ModuleLoadFinished callbacks for dynamic modules #77533

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

davmason
Copy link
Member

Backport of #77068 to release/7.0

Customer Impact

In 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016

Testing

Customer tested that the scenario is fixed with a private build

Risk

Low, the fix is targeted and very few lines of code

@ghost
Copy link

ghost commented Oct 27, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #77068 to release/7.0

Customer Impact

In 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016

Testing

Customer tested that the scenario is fixed with a private build

Risk

Low, the fix is targeted and very few lines of code

Author: davmason
Assignees: -
Labels:

area-AssemblyLoader-coreclr

Milestone: -

@ghost
Copy link

ghost commented Oct 27, 2022

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #77068 to release/7.0

Customer Impact

In 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016

Testing

Customer tested that the scenario is fixed with a private build

Risk

Low, the fix is targeted and very few lines of code

Author: davmason
Assignees: davmason
Labels:

Servicing-consider, area-Diagnostics-coreclr

Milestone: -

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review and we will take for consideration in 7.0.x

@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 27, 2022
@rbhanda rbhanda modified the milestones: 7.0.x, 7.0.1 Oct 27, 2022
@davmason davmason requested a review from a team October 28, 2022 08:18
@carlossanlop
Copy link
Member

Approved by Tactics.
Signed off by area owner.
No OOB package authoring changes needed for this.
CI is green.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 328f53c into dotnet:release/7.0 Nov 3, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants