-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release/7.0] Issue ICorProfiler ModuleLoadFinished callbacks for dynamic modules #77533
[Release/7.0] Issue ICorProfiler ModuleLoadFinished callbacks for dynamic modules #77533
Conversation
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #77068 to release/7.0 Customer ImpactIn 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016 TestingCustomer tested that the scenario is fixed with a private build RiskLow, the fix is targeted and very few lines of code
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #77068 to release/7.0 Customer ImpactIn 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016 TestingCustomer tested that the scenario is fixed with a private build RiskLow, the fix is targeted and very few lines of code
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved. please get a code review and we will take for consideration in 7.0.x
Approved by Tactics. |
Backport of #77068 to release/7.0
Customer Impact
In 7.0 we introduced a regression where we do not issue ModuleLoadFinished callbacks for dynamic modules. ModuleLoadFinished is the opportunity for profilers to change metadata/IL in the target assembly. We have a customer reporting this as blocking in #76016
Testing
Customer tested that the scenario is fixed with a private build
Risk
Low, the fix is targeted and very few lines of code