Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branding to 7.0.1 #77549

Conversation

vseanreesermsft
Copy link

No description provided.

@ghost
Copy link

ghost commented Oct 27, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vseanreesermsft
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ViktorHofer
Copy link
Member

I don't know the specifics, but I assume that we don't want to merge this before we release 7.0?

@carlossanlop
Copy link
Member

I don't know the specifics, but I assume that we don't want to merge this before we release 7.0?

Confirmed with Matt that we're ok merging this much earlier than usual, it was an explicit request. Also, he mentioned we normally put branding PRs out the week before release (mentioning it here for future reference).

@lewing
Copy link
Member

lewing commented Oct 31, 2022

@radical please take a look at the wbt failures.

@radical
Copy link
Member

radical commented Oct 31, 2022

The fix for this is in #76939 , which was waiting on an updated installer with dotnet/sdk#28627 . I'm rebuilding that PR on CI.

@radical
Copy link
Member

radical commented Oct 31, 2022

This needs two fixes:

  1. [release/7.0][wasm] Fix Wasm.Build.Tests with stable 7.0.0 #76939, and that needs ..
  2. SDK fix Return workload manifests in defined, controllable order sdk#28627, and it will be usable when the fix shows up in a new 7.0 installer.

But ..

  1. the installer will be getting the fix from (2) in its release/7.0.2xx branch, IIUC
  2. but the SDK PR to get the fix into release/7.0.2xx is still open - [automated] Merge branch 'release/7.0.1xx' => 'release/7.0.2xx' sdk#28668

So:

  • (4) needs to merge
  • then (3) needs to be updated, and merged
  • then wait for a new installer (will that be on the same 7.0 channel for dotnet-install script?), and merge (1)
  • Then this PR should be green

🤞

eng/Versions.props Outdated Show resolved Hide resolved
@radical
Copy link
Member

radical commented Nov 1, 2022

update: I'm disabling the failing tests in #76939 , that way we won't have to wait to get a new installer build with the sdk fix, since that take some time to be available.

@carlossanlop
Copy link
Member

update: I'm disabling the failing tests in #76939 , that way we won't have to wait to get a new installer build with the sdk fix, since that take some time to be available.

So does that mean I can consider this PR is unblocked and merge it?

@radical
Copy link
Member

radical commented Nov 2, 2022

update: I'm disabling the failing tests in #76939 , that way we won't have to wait to get a new installer build with the sdk fix, since that take some time to be available.

So does that mean I can consider this PR is unblocked and merge it?

No, it still has some fixes that are needed here. So, once we merge that, this will be unblocked. The difference from earlier being that we won't have to wait to get a new installer build with the fix.

@radical
Copy link
Member

radical commented Nov 2, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical removed the blocked Issue/PR is blocked on something - see comments label Nov 2, 2022
@carlossanlop
Copy link
Member

Merging as the CI failures look unrelated, and the timeouts are due to ongoing helix problems. We'll be monitoring the rollout builds.

@carlossanlop carlossanlop merged commit 7c2344a into dotnet:release/7.0 Nov 2, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants