-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update branding to 7.0.1 #77549
Update branding to 7.0.1 #77549
Conversation
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Detailsnull
|
I don't know the specifics, but I assume that we don't want to merge this before we release 7.0? |
Confirmed with Matt that we're ok merging this much earlier than usual, it was an explicit request. Also, he mentioned we normally put branding PRs out the week before release (mentioning it here for future reference). |
@radical please take a look at the wbt failures. |
The fix for this is in #76939 , which was waiting on an updated installer with dotnet/sdk#28627 . I'm rebuilding that PR on CI. |
This needs two fixes:
But ..
So:
🤞 |
update: I'm disabling the failing tests in #76939 , that way we won't have to wait to get a new installer build with the sdk fix, since that take some time to be available. |
So does that mean I can consider this PR is unblocked and merge it? |
No, it still has some fixes that are needed here. So, once we merge that, this will be unblocked. The difference from earlier being that we won't have to wait to get a new installer build with the fix. |
/azp run runtime-wasm |
Azure Pipelines successfully started running 1 pipeline(s). |
Merging as the CI failures look unrelated, and the timeouts are due to ongoing helix problems. We'll be monitoring the rollout builds. |
No description provided.