[release/7.0] Correct minimum memory size value from 200MB to 20MB #77787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
vargaz and
lambdageek
as code owners
vargaz
approved these changes
Nov 2, 2022
|
@akoeplinger @vargaz this needs to go through Tactics. Can one of you please fill out the template and send the email to request approval? |
|
And when ready, please add the |
rbhanda
added
Servicing-approved
|
The re-run came mostly green. The only CI failure seems to be an unrelated nuget download problem with the following error, which I reported to FR, and I was told this is another instance of dotnet/arcade#10885 : Aside from that: Signed off by area owner, approved by Tactics, no need for OOB package authoring changes. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #77682 to release/7.0
/cc @akoeplinger @nealef
Customer Impact
Typo caused value to be 200MB instead of 20MB which caused an incorrect calculation of the cgroup minimum memory size. This prevented mono on s390x from observing memory limits when running inside containers.
Testing
CI testing.
Risk
Low.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.