Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not dehydrate data if CFG is enabled #78546

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Do not dehydrate data if CFG is enabled #78546

merged 1 commit into from
Nov 18, 2022

Conversation

MichalStrehovsky
Copy link
Member

@MichalStrehovsky MichalStrehovsky commented Nov 18, 2022 •
edited
Loading

Three reasons:

  1. CFG is already bigger because of all the extra checks. It's by design.
  2. We might prefer to keep as many things readonly as possible.
  3. This way at least some testing will run to ensure we didn't regress the non-dehydrated configuration.

Cc @dotnet/ilc-contrib

@MichalStrehovsky
Do not dehydrate data if CFG is enabled
f7d7cb5 
Two reasons:
1. CFG is already bigger because of all the extra checks. It's by design.
2. We might prefer to keep as many things readonly as possible.
3. This way at least some testing will run to ensure we didn't regress the non-dehydrated configuration.
@ghost
Copy link

ghost commented Nov 18, 2022

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Three reasons:

  1. CFG is already bigger because of all the extra checks. It's by design.
  2. We might prefer to keep as many things readonly as possible.
  3. This way at least some testing will run to ensure we didn't regress the non-dehydrated configuration.
Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-NativeAOT-coreclr
Milestone: -

@jkotas jkotas merged commit 0eabf7f into dotnet:main Nov 18, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakobbotsch jakobbotsch jakobbotsch approved these changes

@jkotas jkotas jkotas approved these changes

Assignees

@MichalStrehovsky MichalStrehovsky

Labels
area-NativeAOT-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichalStrehovsky @jkotas @jakobbotsch