Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the name/assembly of XmlWriterInlineDataDiscoverer. #78595

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Nov 19, 2022

No description provided.

@ghost
Copy link

ghost commented Nov 19, 2022

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: vargaz
Assignees: -
Labels:

area-System.Xml

Milestone: -

@vargaz
Copy link
Contributor Author

vargaz commented Nov 19, 2022

This was broken by 8de1809.

This wasn't discovered because xunit seems to silently ignore the error, the tests
decorated with the attribute are simply skipped.

@vargaz
Copy link
Contributor Author

vargaz commented Nov 19, 2022

The wasm failure is
#78358

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub merged commit 37cb86c into dotnet:main Nov 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants