Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Correctly escape library names when generating symbols for .c #79007

Merged
merged 8 commits into from
Nov 30, 2022
Merged

[wasm] Correctly escape library names when generating symbols for .c #79007

merged 8 commits into from
Nov 30, 2022

Commits on Nov 29, 2022

  1. [wasm] Correctly escape library names when generating symbols for .c 

    .. files.

Use th existing `FixupSymbolName` method for fixing library names too,
when converting to symbols.

Fixes dotnet#78992 .
    @radical
    radical committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    976abf0 View commit details
    Browse the repository at this point in the history

  2. [wasm] PInvokeTableGenerator: Use FixupSymbolName in more places

    @radical
    radical committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    218c890 View commit details
    Browse the repository at this point in the history

  3. [wasm] *TableGenerator task: Cache the symbol name fixups 

    .. as it is called frequently, and for repeated strings. For a
consolewasm template build, we get 490 calls but only 140 of them are
for unique strings.
    @radical
    radical committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    985f6d5 View commit details
    Browse the repository at this point in the history

  4. [wasm] IcallTableGenerator: fixup assembly name also, when used as a … 

    …symbol
    @radical
    radical committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    7e6718c View commit details
    Browse the repository at this point in the history

  5. cleanup

    @radical
    radical committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    a35bce8 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. Merge remote-tracking branch 'origin/main' into pinvoke-escape-name

    @radical
    radical committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    edec2a9 View commit details
    Browse the repository at this point in the history

  2. Add tests

    @radical
    radical committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    8ea2884 View commit details
    Browse the repository at this point in the history

  3. rename test

    @radical
    radical committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    afb6ef3 View commit details
    Browse the repository at this point in the history