Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove page map from PAL virtual memory allocator #80105

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

janvorli
Copy link
Member

@janvorli janvorli commented Jan 2, 2023

This change removes the page map from the PAL virtual memory allocator. This map is only used for the VirtualQuery API implementation and the usage of that API in the runtime actually only care about whether a virtual memory range is free or not (it doesn't care about whether the memory is reserved or committed, and it doesn't care about the actual protection).

@janvorli janvorli added this to the 8.0.0 milestone Jan 2, 2023
@janvorli janvorli requested a review from jkotas January 2, 2023 22:39
@janvorli janvorli self-assigned this Jan 2, 2023
@janvorli
Copy link
Member Author

janvorli commented Jan 2, 2023

cc: @mangod9

Copy link
Member

@mangod9 mangod9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, certainly feels less risky than the full GC PAL change.

@jkotas
Copy link
Member

jkotas commented Jan 2, 2023

Is ClrVirtualAllocWithinRange the only place where VirtualQuery is called on Unix?

@janvorli
Copy link
Member Author

janvorli commented Jan 2, 2023

Is ClrVirtualAllocWithinRange the only place where VirtualQuery is called on Unix?

Yes, that's the only one.

@janvorli
Copy link
Member Author

janvorli commented Jan 4, 2023

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3838505566

@ghost ghost locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants