Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Fix thread-safety issues with enumerating ResourceManager. #81283

Merged
merged 7 commits into from
Mar 10, 2023

Commits on Feb 10, 2023

  1. Fix thread-safety issues with enumerating ResourceManager.

    Concurrently enumerating a ResourceManager while also calling GetString()
    and similar methods was prone to both transient errors and deadlock.
    
    The transient errors were caused by RuntimeResourceSet calling internal
    methods on ResourceReader that did not properly lock. Now, all exposed
    methods on the Reader are thread-safe.
    
    The deadlock was called by inconsistent lock ordering between
    ResourceReader.ResourceEnumerator and RuntimeResourceSet which both lock
    on the RuntimeResourceSet's cache and on the ResourceReader itself. Now,
    the enumerator does not need to take both locks at the same time.
    
    Fix #74052
    Fix #74868
    madelson authored and carlossanlop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3b33698 View commit details
    Browse the repository at this point in the history
  2. Remove trailing whitespace

    madelson authored and carlossanlop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    991d205 View commit details
    Browse the repository at this point in the history
  3. Address feedback from #75054

    madelson authored and carlossanlop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f215ba2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    478b697 View commit details
    Browse the repository at this point in the history
  5. Implement feedback from #75054

    madelson authored and carlossanlop committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    faba965 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d57ec7e View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Configuration menu
    Copy the full SHA
    9ed9839 View commit details
    Browse the repository at this point in the history