Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix condition for module registration export #81765

Merged
merged 2 commits into from
Feb 7, 2023

Conversation

am11
Copy link
Member

@am11 am11 commented Feb 7, 2023

HOST_LINUX is only defined in mono. Here, we wanted to export this symbol on linux, and skip during the cross-compile (from Windows which doesn't use PAL).

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Feb 7, 2023
@am11 am11 changed the title FIx condition for module registration export Fix condition for module registration export Feb 7, 2023
@ghost
Copy link

ghost commented Feb 7, 2023

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

HOST_LINUX is only defined in mono. Here, we wanted to export this symbol on linux, and skip during the cross-compile (from Windows which doesn't use PAL).

Author: am11
Assignees: -
Labels:

area-Diagnostics-coreclr, community-contribution

Milestone: -

@am11 am11 requested a review from mikem8361 February 7, 2023 17:11
@am11
Copy link
Member Author

am11 commented Feb 7, 2023

Failure is unrelated (#76905).

@mikem8361 mikem8361 merged commit 2125b8b into dotnet:main Feb 7, 2023
@am11 am11 deleted the feature/coreclr/mscordbi-exports branch February 7, 2023 23:16
@ghost ghost locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Diagnostics-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants