Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[main] Update dependencies from dotnet/roslyn" #82466

Merged

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Feb 22, 2023

Reverts #81164

This PR caused heavy managed build regressions hitting all PR builds. See #82583 and #76454

@hoyosjs hoyosjs requested review from jkoritzinsky and removed request for lewing, marek-safar and pavelsavara February 22, 2023 06:35
@ghost ghost assigned hoyosjs Feb 22, 2023
@hoyosjs hoyosjs requested review from eiriktsarpalis and a team February 22, 2023 06:36
@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 22, 2023

cc: @jaredpar in case it's interesting to you

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the project file changes and the change in the trimmer analyzer? Those are general goodness.

@ViktorHofer
Copy link
Member

Can you keep the project file changes

@jkoritzinsky why keep those if the generator is referenced implicitly anyway in generators.targets? Maybe I'm missing something?

@pavelsavara
Copy link
Member

Can you keep the project file changes

@jkoritzinsky why keep those if the generator is referenced implicitly anyway in generators.targets? Maybe I'm missing something?

@ViktorHofer I hope I understand your question well.

generators.targets only references Microsoft.Interop.SourceGeneration for [LibraryImport] not for [JSImport].

I added the references to the individual projects because the logic in generators.targets was overly complex. But maybe we could try again.

If we don't add it, we could get errors like these.

CSC : error CS8784: Generator 'JSExportGenerator' failed to initialize. It will not contribute to the output and compilation errors may occur as a result. Exception was of type 'FileNotFoundException' with message 
'Could not load file or assembly 'Microsoft.Interop.SourceGeneration, Version=42.42.42.42, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.' 
[D:\a\_work\1\s\src\libraries\System.Net.WebSockets.Client\src\System.Net.WebSockets.Client.csproj::TargetFramework=net8.0-browser]

The roslyn process doesn't have correct version of Microsoft.Interop.SourceGeneration on PATH otherwise.

@lewing
Copy link
Member

lewing commented Feb 22, 2023

If we want to just revert the Version** bump that would be fine

@hoyosjs hoyosjs force-pushed the revert-81164-darc-main-5410199c-3511-41c9-8178-d0c10ae042d9 branch from ff0bd7c to 82a24c8 Compare February 22, 2023 17:47
@hoyosjs
Copy link
Member Author

hoyosjs commented Feb 22, 2023

Merging to unblock PRs

@hoyosjs hoyosjs merged commit 98bf267 into main Feb 22, 2023
@hoyosjs hoyosjs deleted the revert-81164-darc-main-5410199c-3511-41c9-8178-d0c10ae042d9 branch February 22, 2023 18:45
@ghost ghost locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants