Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] remove unused methods #82865

Merged
merged 1 commit into from
Mar 2, 2023
Merged

[browser] remove unused methods #82865

merged 1 commit into from
Mar 2, 2023

Conversation

pavelsavara
Copy link
Member

removed unused legacy JS interop helpers

mono_wasm_unbox_enum
mono_wasm_invoke_method
mono_wasm_string_get_utf8
mono_wasm_string_from_js
mono_wasm_get_obj_class
mono_wasm_string_get_data
mono_wasm_type_get_class
mono_wasm_get_obj_type
_wasm_get_obj_type_ref_impl
mono_wasm_array_get

@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 1, 2023
@pavelsavara pavelsavara requested review from kg and maraf March 1, 2023 23:05
@pavelsavara pavelsavara self-assigned this Mar 1, 2023
@ghost
Copy link

ghost commented Mar 1, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

removed unused legacy JS interop helpers

mono_wasm_unbox_enum
mono_wasm_invoke_method
mono_wasm_string_get_utf8
mono_wasm_string_from_js
mono_wasm_get_obj_class
mono_wasm_string_get_data
mono_wasm_type_get_class
mono_wasm_get_obj_type
_wasm_get_obj_type_ref_impl
mono_wasm_array_get
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara mentioned this pull request Mar 1, 2023
Merged
@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara pavelsavara marked this pull request as ready for review March 2, 2023 07:01
@pavelsavara pavelsavara requested a review from lewing as a code owner March 2, 2023 07:01
@pavelsavara
Copy link
Member Author

CI failure FetchError: request failed, reason: Parse Error: Invalid header value char is unrelated

@pavelsavara pavelsavara merged commit e7926d6 into dotnet:main Mar 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Apr 1, 2023
@pavelsavara pavelsavara deleted the browser_remove_unused branch September 2, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf