Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use PlatformSpecific attribute to supress platform specific Quic tests #82933

Merged
merged 2 commits into from
Mar 3, 2023
Merged

use PlatformSpecific attribute to supress platform specific Quic tests #82933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5598ce
use PlatformSpecific attribute to supress platform specific Quic tests
wfurt Mar 3, 2023
25cd41a
Update src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlat…
wfurt Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/libraries/System.Net.Quic/tests/FunctionalTests/MsQuicPlatformDetectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,17 @@ public void UnsupportedPlatforms_ThrowsPlatformNotSupportedException()

[ActiveIssue("https://github.com/dotnet/runtime/issues/73290", typeof(PlatformDetection), nameof(PlatformDetection.IsSingleFile))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82885", typeof(PlatformDetection), nameof(PlatformDetection.IsArm64Process))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsWindows), nameof(PlatformDetection.SupportsTls13))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.SupportsTls13))]
[PlatformSpecific(TestPlatforms.Windows)]
public void SupportedWindowsPlatforms_IsSupportedIsTrue()
{
Assert.True(QuicListener.IsSupported);
Assert.True(QuicConnection.IsSupported);
}

[ActiveIssue("https://github.com/dotnet/runtime/issues/81901", typeof(PlatformDetection), nameof(PlatformDetection.IsAlpine314), nameof(PlatformDetection.IsInContainer))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux))]
[Fact]
[PlatformSpecific(TestPlatforms.Linux)]
public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
{
using Process find = new Process();
Expand Down Expand Up @@ -61,7 +63,8 @@ public async Task SupportedLinuxPlatformsWithMsQuic_IsSupportedIsTrue()
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsRaspbian10), nameof(PlatformDetection.IsArmv6Process), nameof(PlatformDetection.IsInContainer))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsPpc64leProcess))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/82154", typeof(PlatformDetection), nameof(PlatformDetection.IsUbuntu2004), nameof(PlatformDetection.IsS390xProcess))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsLinux), nameof(PlatformDetection.IsInHelix))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInHelix))]
[PlatformSpecific(TestPlatforms.Linux)]
wfurt marked this conversation as resolved.
Show resolved Hide resolved
public void SupportedLinuxPlatforms_IsSupportedIsTrue()
{
_output.WriteLine($"Running on {PlatformDetection.GetDistroVersionString()}");
Expand Down