Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JIT] Add support to inline the field access of primitive types marked with TLS #82973

Merged
merged 93 commits into from
Apr 11, 2023
Merged

[JIT] Add support to inline the field access of primitive types marked with TLS #82973

merged 93 commits into from
Apr 11, 2023

Commits on Feb 17, 2023

  1. Add CORINFO_THREAD_LOCAL_FIELD_INFO and getThreadLocalFieldInfo()

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    327b8f6 View commit details
    Browse the repository at this point in the history

  2. Implementation of getThreadLocalFieldInfo()

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    51644e2 View commit details
    Browse the repository at this point in the history

  3. Change the field types from CORINFO_CONST_LOOKUP to uint32_t

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    8aef324 View commit details
    Browse the repository at this point in the history

  4. Introduce CORINFO_FIELD_STATIC_TLS_MANAGED

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    916482b View commit details
    Browse the repository at this point in the history

  5. Introduce GTF_FLD_TLS_MANAGED

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    6eaa3d9 View commit details
    Browse the repository at this point in the history

  6. Introduce eeGetThreadLocalFieldInfo()

    @kunalspathak
    kunalspathak committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    efbb53d View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Fix the offsetOfThreadStaticBlocks, hardcode threadStaticBlockIndex f… 

    …or now
    @kunalspathak
    kunalspathak committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    f3fc3a2 View commit details
    Browse the repository at this point in the history

  2. Add impThreadLocalFieldAccess()

    @kunalspathak
    kunalspathak committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ca4caad View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Switch to GS segment register with a TODO

    @kunalspathak
    kunalspathak committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8fd9f58 View commit details
    Browse the repository at this point in the history

  2. Add reverse map g_threadStaticBlockTypeIDMap for type -> ID

    @kunalspathak
    kunalspathak committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b0bf47f View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Fix GS segment register encoding

    @kunalspathak
    kunalspathak committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    3796c73 View commit details
    Browse the repository at this point in the history

  2. Add comment for g_threadStaticBlockTypeIDMap

    @kunalspathak
    kunalspathak committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    50c5e95 View commit details
    Browse the repository at this point in the history

  3. Add extra parameter for typeIndex in JIT_GetSharedNonGCThreadStaticBase

    @kunalspathak
    kunalspathak committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    8d0c3a9 View commit details
    Browse the repository at this point in the history

  4. Update JIT_GetSharedNonGCThreadStaticBase to add logic for storing ty… 

    …peIndex in t_threadStaticBlocks
    @kunalspathak
    kunalspathak committed Feb 25, 2023
    Configuration menu
    Copy the full SHA
    45ddb20 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. Fix encoding of gs:[0x58]

    @kunalspathak
    kunalspathak committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    8ca4999 View commit details
    Browse the repository at this point in the history

  2. fix some bugs in importer to change size from 4 to 8

    @kunalspathak
    kunalspathak committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    93a70a1 View commit details
    Browse the repository at this point in the history

  3. add some printf in jithelpers

    @kunalspathak
    kunalspathak committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    a0e40f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. To revert

    @kunalspathak
    kunalspathak committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e6bdd82 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    8548500 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. Update the helper to skip making re-entry for staticBlock

    @kunalspathak
    kunalspathak committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    f3bca52 View commit details
    Browse the repository at this point in the history

  2. Add impThreadLocalFieldWrite() for store

    @kunalspathak
    kunalspathak committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    93702e3 View commit details
    Browse the repository at this point in the history

  3. Fix a issue for helper

    @kunalspathak
    kunalspathak committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a607458 View commit details
    Browse the repository at this point in the history

  4. Use JITDUMP

    @kunalspathak
    kunalspathak committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    c331a68 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    a96745f View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Just enable the optimization for primitive types

    @kunalspathak
    kunalspathak committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    b3e1038 View commit details
    Browse the repository at this point in the history

  2. Update the JITEE guid

    @kunalspathak
    kunalspathak committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    3a20176 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. Fix an assert for volatile variables

    @kunalspathak
    kunalspathak committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    db09d6f View commit details
    Browse the repository at this point in the history

  2. Mark helper block as cold block

    @kunalspathak
    kunalspathak committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    58cdade View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. wip

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    a138959 View commit details
    Browse the repository at this point in the history

  2. Fix the size of maxThreadStaticBlock

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    8d0d6a7 View commit details
    Browse the repository at this point in the history

  3. fix a bug to insert the entry in cache

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e372a95 View commit details
    Browse the repository at this point in the history

  4. Add #ifdef for HOST_WINDOWS / TARGET_WINDOWS

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b273fe6 View commit details
    Browse the repository at this point in the history

  5. Dynamic memory allocation for static block array

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9584257 View commit details
    Browse the repository at this point in the history

  6. Call InitTypeMap only if host == windows

    @kunalspathak
    kunalspathak committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d0bbf56 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Add CORINFO_HELP_GETSHARED_NONGCTHREADSTATIC_BASE_NOCTOR_OPTIMIZED

    @kunalspathak
    kunalspathak committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6e10e7d View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    c5266da View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Expand the TLS field access in late phase

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    360ab8c View commit details
    Browse the repository at this point in the history

  2. Move rarely ran block to the end

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    3dfb3d2 View commit details
    Browse the repository at this point in the history

  3. wip

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    0e3daaa View commit details
    Browse the repository at this point in the history

  4. Fix the bug to access the value from fastPath

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7f59353 View commit details
    Browse the repository at this point in the history

  5. Remove code from importer

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e618aee View commit details
    Browse the repository at this point in the history

  6. Cleanup the code

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    2b0629d View commit details
    Browse the repository at this point in the history

  7. Moved CreateBlockFromTree to fgbasic.cpp

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    a4bb8dd View commit details
    Browse the repository at this point in the history

  8. Move fgExpandThreadLocalAccess() to flowgraph.cpp

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    bad7fb3 View commit details
    Browse the repository at this point in the history

  9. Add getThreadLocalStaticBlocksInfo() method

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    e094f29 View commit details
    Browse the repository at this point in the history

  10. Consume getThreadLocalStaticBlocksInfo() method

    @kunalspathak
    kunalspathak committed Mar 28, 2023
    Configuration menu
    Copy the full SHA
    7b9de56 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Updated definition of getThreadLocalFieldInfo()

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    781e25e View commit details
    Browse the repository at this point in the history

  2. Rename CORINFO_THREAD_LOCAL_FIELD_INFO to CORINFO_THREAD_STATIC_BLOCK… 

    …S_INFO
    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f774eb5 View commit details
    Browse the repository at this point in the history

  3. Add TARGET_WINDOWS

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    76cbaa1 View commit details
    Browse the repository at this point in the history

  4. Make TARGET_WINDOWS at some definitions

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    097a2d4 View commit details
    Browse the repository at this point in the history

  5. Add dummy definition for unix

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    d718156 View commit details
    Browse the repository at this point in the history

  6. jit format

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    20f2e90 View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    612187e View commit details
    Browse the repository at this point in the history

  8. remote unnecessary code from morph

    @kunalspathak
    kunalspathak committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    69f64cf View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. Fix an issue on linux, add assert for tls_index != 0

    @kunalspathak
    kunalspathak committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5e53c84 View commit details
    Browse the repository at this point in the history

  2. Convert from TARGET_WINDOWS to HOST_WINDOWS

    @kunalspathak
    kunalspathak committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    5f4b971 View commit details
    Browse the repository at this point in the history

  3. jit format

    @kunalspathak
    kunalspathak committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    8f61268 View commit details
    Browse the repository at this point in the history

  4. fix the if-check

    @kunalspathak
    kunalspathak committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    c3b3c83 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. fix gcc build error

    @kunalspathak
    kunalspathak committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    91f6a8a View commit details
    Browse the repository at this point in the history

  2. Added MethodHaveTlsFieldAccess()

    @kunalspathak
    kunalspathak committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    25c04d5 View commit details
    Browse the repository at this point in the history

  3. Handle the case for '_tls_index == 0'

    @kunalspathak
    kunalspathak committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    90103a1 View commit details
    Browse the repository at this point in the history

  4. fix a typo

    @kunalspathak
    kunalspathak committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    90af395 View commit details
    Browse the repository at this point in the history

  5. Fix windows/arm64 issue

    @kunalspathak
    kunalspathak committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    66f6401 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2023

  1. fix encoding of teb loading for arm64

    @kunalspathak
    kunalspathak committed Apr 1, 2023
    Configuration menu
    Copy the full SHA
    3cd2881 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Fix the condition in jitinterface to select correct helper

    @kunalspathak
    kunalspathak committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    055b9e0 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. fix the condition for other helper too

    @kunalspathak
    kunalspathak committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c8ed0c6 View commit details
    Browse the repository at this point in the history

  2. fix the windows/x86 case

    @kunalspathak
    kunalspathak committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    ab98131 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    6c9264f View commit details
    Browse the repository at this point in the history

  4. jit format

    @kunalspathak
    kunalspathak committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    d085acd View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Use CORINFO_CONST_LOOKUP for _tls_index

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f08fbd3 View commit details
    Browse the repository at this point in the history

  2. Move typeIdMap to BaseDomain class

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a81c4b9 View commit details
    Browse the repository at this point in the history

  3. Introduce useFatPointerDispatch parameter for GetTypeID()

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    18e6b46 View commit details
    Browse the repository at this point in the history

  4. jit format

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d23a0b2 View commit details
    Browse the repository at this point in the history

  5. Do not pass classID and moduleID to the new helper

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    1aea091 View commit details
    Browse the repository at this point in the history

  6. fix build for non-windows

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    19bb28a View commit details
    Browse the repository at this point in the history

  7. fix superpmi methods

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7dc2d6e View commit details
    Browse the repository at this point in the history

  8. review feedback

    @kunalspathak
    kunalspathak committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    2d76689 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. fix linux build errors

    @kunalspathak
    kunalspathak committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    79e0351 View commit details
    Browse the repository at this point in the history

  2. review feedback

    @kunalspathak
    kunalspathak committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    1f2a353 View commit details
    Browse the repository at this point in the history

  3. fix weight inherit

    @kunalspathak
    kunalspathak committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c0de86f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2023

  1. inline JIT_GetNonGCThreadStaticBase_Helper to fix the contract error

    @kunalspathak
    kunalspathak committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    52f98c5 View commit details
    Browse the repository at this point in the history

  2. Remove dead code from helper

    @kunalspathak
    kunalspathak committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    cdd79fd View commit details
    Browse the repository at this point in the history

  3. Add GTF_CALL_M_EXP_TLS_ACCESS to check if we do not revisit the alrea… 

    …dy expanded call node
    @kunalspathak
    kunalspathak committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    bdc67fe View commit details
    Browse the repository at this point in the history

  4. address feedback

    @kunalspathak
    kunalspathak committed Apr 7, 2023
    Configuration menu
    Copy the full SHA
    c9858d4 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2023

  1. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    a7d290f View commit details
    Browse the repository at this point in the history

  2. regenerate the files

    @kunalspathak
    kunalspathak committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    4f20569 View commit details
    Browse the repository at this point in the history

  3. Introduce fgExpandHelper and fgExpandHelperForBlock and reuse it for … 

    …various helper expansion
    @kunalspathak
    kunalspathak committed Apr 8, 2023
    Configuration menu
    Copy the full SHA
    746fd04 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2023

  1. fix the typo

    @kunalspathak
    kunalspathak committed Apr 9, 2023
    Configuration menu
    Copy the full SHA
    b734406 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. update the assert for runtimelookup

    @kunalspathak
    kunalspathak committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    c67b085 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into tls

    @kunalspathak
    kunalspathak committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    fc6bb0c View commit details
    Browse the repository at this point in the history

  3. check if we should skip rarely run blocks

    @kunalspathak
    kunalspathak committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    047a6ef View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. review feedback

    @kunalspathak
    kunalspathak committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    30d19d9 View commit details
    Browse the repository at this point in the history

  2. Remove GTF_IND_INVARIANT from typeIndex access because it produces … 

    …nullptr 1st time and valid value 2nd time onwards
    @kunalspathak
    kunalspathak committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    be29dcb View commit details
    Browse the repository at this point in the history