fix failing ConnectWithRevocation_ServerCertWithoutContext_NoStapleOcsp failures

[wfurt]

There was mismatch between the test and product. When context is created from certificate internally, the code defaults to OCSP processing

runtime/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.cs

Lines 21 to 24 in 4eca676

	public static SslStreamCertificateContext Create(X509Certificate2 target, X509Certificate2Collection? additionalCertificates, bool offline = false, SslCertificateTrust? trust = null)
	{
	return Create(target, additionalCertificates, offline, trust, noOcspFetch: false);
	}

(negative false -> oof ;( )

So the server would provide OCSP response and based on the timing the test would succeed or fail.

I was thinking about deleting the test but I decided to keep it and modify the behavior instead.
This would IMHO preserve legacy behavior. When single certificate is used it would act as it always did - e.g. no OCSP.

When SslStreamCertificateContext is created and provided by user we would take is as intention to reuse it over time and we would handle TLS resume & OCSP. This is currently recommended use as it also offers other performance benefits.

fixes #70981

[ghost]

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

---

There was mismatch between the test and product. When context is created from certificate internally, the code defaults to OCSP processing

runtime/src/libraries/System.Net.Security/src/System/Net/Security/SslStreamCertificateContext.cs

Lines 21 to 24 in 4eca676

	public static SslStreamCertificateContext Create(X509Certificate2 target, X509Certificate2Collection? additionalCertificates, bool offline = false, SslCertificateTrust? trust = null)
	{
	return Create(target, additionalCertificates, offline, trust, noOcspFetch: false);
	}

(negative false -> oof ;( )

So the server would provide OCSP response and based on the timing the test would succeed or fail.

I was thinking about deleting the test but I decided to keep it and modify the behavior instead.
This would IMHO preserve legacy behavior. When single certificate is used it would act as it always did - e.g. no OCSP.

When SslStreamCertificateContext is created and provided by user we would take is as intention to reuse it over time and we would handle TLS resume & OCSP. This is currently recommended use as it also offers other performance benefits.

fixes #70981

Author:	wfurt
Assignees:	wfurt
Labels:	area-System.Net.Security, os-linux
Milestone:	-

[wfurt]

windows test failure is #83110