Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] partial reversal of PR #82826 #83637

Merged

Conversation

pavelsavara
Copy link
Member

There is problem in Blazor E2E test with protecting the class System.Runtime.InteropServices.JavaScript.LegacyExports from trimming.

It seems in some scenario the root file ILLink.Descriptors.LegacyJsInterop.xml is not available and the class is trimmed even if we still should have it.

I believe that this PR would be enough revert of the original #82826
We should use it in case that we can't figure out better fix.

@pavelsavara pavelsavara added this to the 8.0.0 milestone Mar 18, 2023
@pavelsavara pavelsavara requested a review from maraf March 18, 2023 14:18
@pavelsavara pavelsavara self-assigned this Mar 18, 2023
@ghost
Copy link

ghost commented Mar 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

There is problem in Blazor E2E test with protecting the class System.Runtime.InteropServices.JavaScript.LegacyExports from trimming.

It seems in some scenario the root file ILLink.Descriptors.LegacyJsInterop.xml is not available and the class is trimmed even if we still should have it.

I believe that this PR would be enough revert of the original #82826
We should use it in case that we can't figure out better fix.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript

Milestone: 8.0.0

@pavelsavara

This comment was marked as outdated.

@wtgodbe
Copy link
Member

wtgodbe commented Mar 21, 2023

@maraf any idea why this is failing?

If we understand the failures and can fix them, I think we should port this to the preview3 branch instead of #83664 in order to unblock runtime -> aspnetcore codeflow (CC @mmitche)

Related: dotnet/aspnetcore#47110

@maraf
Copy link
Member

maraf commented Mar 21, 2023

Failures are not related.
I'll test it once again locally if it's enough change for blazor to work.

@maraf maraf marked this pull request as draft March 21, 2023 20:07
@maraf maraf marked this pull request as ready for review March 21, 2023 20:07
@maraf maraf merged commit 6047cdc into dotnet:main Mar 21, 2023
@maraf

This comment was marked as off-topic.

@github-actions

This comment was marked as off-topic.

@github-actions

This comment was marked as off-topic.

@maraf
Copy link
Member

maraf commented Mar 21, 2023

/backport to release/8.0-preview3

@github-actions
Copy link
Contributor

Started backporting to release/8.0-preview3: https://github.com/dotnet/runtime/actions/runs/4483993832

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants