Mitigation for #84446: comment out problematic JIT assertion check #84449
Conversation
The most recent aggregated runtime MIBC optimization data contains a combination of block and edge counts, possibly after a change from January 2023 that switched MIBC logic over from using block counts to edge counts. The offending assertion check wasn't expecting it and started crashing Crossgen2 during compilation of System.Private.CoreLib on Windows x64 / arm. Based on Andy Ayers' advice I'm proposing to comment out the assertion check; I have created the tracking issue dotnet#84446 to follow up on consolidation of JIT and MIBC production logic in this respect. Thanks Tomas
trylek
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak Issue DetailsThe most recent aggregated runtime MIBC optimization data contains a combination of block and edge counts, possibly after a change from January 2023 that switched MIBC logic over from using block counts to edge counts. The offending assertion check wasn't expecting it and started crashing Crossgen2 during compilation of System.Private.CoreLib on Windows x64 / arm. Based on Andy Ayers' advice I'm proposing to comment out the assertion check; I have created the tracking issue #84446 to follow up on consolidation of JIT and MIBC production logic in this respect. Thanks Tomas /cc @dotnet/jit-contrib, @dotnet/crossgen-contrib
|
|
Thanks Andy for the primary suggestion and for the approval, the [NO-MERGE] version of this PR has just passed SPC Crossgen2 compilation on Windows x64. I plan to merge this in tomorrow morning provided the lab run is clean unless I receive blocking feedback. |
The most recent aggregated runtime MIBC optimization data contains a combination of block and edge counts, possibly after a change from January 2023 that switched MIBC logic over from using block counts to edge counts. The offending assertion check wasn't expecting it and started crashing Crossgen2 during compilation of System.Private.CoreLib on Windows x64 / arm. Based on Andy Ayers' advice I'm proposing to comment out the assertion check; I have created the tracking issue #84446 to follow up on consolidation of JIT and MIBC production logic in this respect.
Thanks
Tomas
/cc @dotnet/jit-contrib, @dotnet/crossgen-contrib
Expected to unblock PR: #83624