[release/7.0-staging] Fix AwaitableSocketAsyncEventArgs reorderings on weaker memory models #84641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There are a couple of places where we read the _continuation field and then read some other state which we assume to be consistent with the value we read in _continuation. But without a fence, those secondary reads could be reordered with respect to the first.
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #84432 to release/7.0-staging /cc @stephentoub Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffhandley
approved these changes
Apr 11, 2023
MihaZupan
approved these changes
Apr 11, 2023
jeffhandley
changed the title
leecow
added
Servicing-approved
This was referenced Apr 12, 2023
|
@carlossanlop, with this targeting staging, I can merge this now, right? |
|
Correct.
Do the honors. Smash the squash&merge button. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #84432 to release/7.0-staging
/cc @stephentoub
Customer Impact
Testing
Risk
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.