Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store unhandled exception info on stack in Native AOT #84871

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Store unhandled exception info on stack in Native AOT #84871

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dda1f63
Attempt to fix #84636
agocke Apr 15, 2023
fc78b8b
Respond to PR comments
agocke Apr 18, 2023
2772bb1
Respond to PR comments
agocke Apr 18, 2023
0855ee4
PR comments
agocke Apr 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/coreclr/nativeaot/System.Private.CoreLib/src/System/RuntimeExceptionHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,19 @@ internal static void FailFast(string message, Exception? exception, RhFailFastRe
outputMessage = message;
}

if (outputMessage != null)
agocke marked this conversation as resolved.
Show resolved Hide resolved
{
// Try to save the exception stack trace in a buffer on the stack. If the exception is too large, we'll truncate it.
const int MaxStack = 1024;
Span<char> exceptionStack = stackalloc char[MaxStack];

int length = Math.Max(MaxStack, outputMessage.Length);
outputMessage.AsSpan().Slice(0, length).CopyTo(exceptionStack);
agocke marked this conversation as resolved.
Show resolved Hide resolved
// Fill the rest of the buffer with nulls
if (length < MaxStack)
exceptionStack.Slice(length).Clear();
agocke marked this conversation as resolved.
Show resolved Hide resolved
}

agocke marked this conversation as resolved.
Show resolved Hide resolved
Internal.Console.Error.Write(prefix);
if (outputMessage != null)
Internal.Console.Error.Write(outputMessage);
Expand Down