Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JIT] ARM64 - Fixed regressions for GT_NEG containment #85230

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Apr 24, 2023

Resolves #85225

@ghost ghost assigned TIHan Apr 24, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 24, 2023
@ghost
Copy link

ghost commented Apr 24, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Resolves #85225

Author: TIHan
Assignees: TIHan
Labels:

area-CodeGen-coreclr

Milestone: -

@TIHan TIHan changed the title [JIT] ARM64 - Fixed regressions for 'GT_NEG' containment on ARM64 [JIT] ARM64 - Fixed regressions for GT_NEG containment Apr 24, 2023
@TIHan
Copy link
Contributor Author

TIHan commented Apr 24, 2023

@dotnet/jit-contrib @jakobbotsch this is ready

@jakobbotsch
Copy link
Member

/azp run Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jakobbotsch
Copy link
Member

Looks like there's still some examples, e.g.:

// Generated by Fuzzlyn v1.5 on 2023-04-24 10:09:34
// Run on Arm64 Linux
// Seed: 15668805006347923926
// Reduced from 103.1 KiB to 0.3 KiB in 00:01:18
// Debug: Outputs False
// Release: Outputs True
public class Program
{
    public static long s_7;
    public static int[] s_11 = new int[]{0};
    public static void Main()
    {
        s_11[0] = -2147483648;
        var vr9 = (int)s_7 < (-s_11[0]);
        System.Console.WriteLine(vr9);
    }
}

@TIHan
Copy link
Contributor Author

TIHan commented Apr 24, 2023

Updated again, this should fix it for good now. I was containing NEG for all comparison ops, but it's only valid for EQ and NE.

@jakobbotsch
Copy link
Member

/azp run Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TIHan
Copy link
Contributor Author

TIHan commented Apr 25, 2023

/azp run Fuzzlyn

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@TIHan
Copy link
Contributor Author

TIHan commented Apr 26, 2023

CI failure is unrelated. Last Fuzzlyn runs succeeded, though it did catch an unrelated case in OSX which I reported here.

@TIHan TIHan merged commit 7a70d5a into dotnet:main Apr 26, 2023
@TIHan TIHan deleted the runtime_85225 branch April 26, 2023 07:08
@ghost ghost locked as resolved and limited conversation to collaborators May 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JIT: Invalid result with negated op in compare on arm64
3 participants