Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some SystemNetSecurity properties public #85402

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Apr 26, 2023

Fixes #67552.

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned rzikm Apr 26, 2023
@ghost
Copy link

ghost commented Apr 26, 2023

Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #67552.

Hopefully I managed to clean up the ApiCompat suppressions correctly.

Author: rzikm
Assignees: -
Labels:

area-System.Net.Security, new-api-needs-documentation

Milestone: -

@rzikm rzikm marked this pull request as draft April 26, 2023 15:50
@rzikm rzikm changed the title 67552-API-Proposal-Make-some-SystemNetSecurity-properties-public Make some SystemNetSecurity properties public Apr 26, 2023
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
The assumption from API review was that the extra collection would not matter for perf reasons.

@rzikm rzikm marked this pull request as ready for review April 27, 2023 07:50
@rzikm
Copy link
Member Author

rzikm commented Apr 27, 2023

CI failures are unrelated

@rzikm rzikm merged commit 4bbde33 into dotnet:main Apr 27, 2023
@karelz karelz added this to the 8.0.0 milestone May 27, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Make some System.Net.Security functions/properties public for System.Net.Quic
3 participants