[release/8.0-preview4] Re-enable PGO for linux #85410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #85355 to release/8.0-preview4 Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Apr 26, 2023
carlossanlop
added
the
Servicing-consider
This was referenced Apr 27, 2023
rbhanda
added
Servicing-approved
agocke
approved these changes
Apr 27, 2023
|
Took a look, test issues are all known (and marked as such by Build Analysis!) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #85355 to release/8.0-preview4
/cc @agocke @sbomer
Customer Impact
This avoids potential perf regressions on linux compared to preview 3 in some scenarios, which shipped with PGO enabled. Perf is expected to improve for the scenarios we optimize for in dotnet-optimization.
Testing
CI testing found no functional issues with the change.
Risk
We haven't seen this change propagate to our perf benchmarks, so we don't know exactly the perf impact. Fortunately, any risk is expected to be perf-related, not correctness-related. Perf is expected to improve for scenarios that we benchmark.
IMPORTANT: If this backport is for a servicing release, please verify that: