[mono][aot] Enabling AOT wrappers for virtual delegates #85643
Conversation
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
LeVladIonescu
added
the
NO-MERGE
LeVladIonescu
requested review from
vargaz,
lambdageek,
SamMonoRT and
thaystg
as code owners
src/mono/mono/mini/aot-compiler.c
Outdated
| @@ -3778,6 +3778,8 @@ encode_method_ref (MonoAotCompile *acfg, MonoMethod *method, guint8 *buf, guint8 | |||
| MonoJumpInfoToken *ji; | |||
| guint8 *p = buf; | |||
|
|
|||
| printf("NAME = %s\n", method->name); | |||
There was a problem hiding this comment.
unrelated change...only for debug reasons
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
LeVladIonescu
changed the title
LeVladIonescu
removed
the
NO-MERGE
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
|
Ready to review / merge. |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@LeVladIonescu - as part of this PR consider enabling any disabled tests fixed by the changes. |
|
@SamMonoRT will check |
| shared_context = mono_class_get_generic_container (method->klass)->context; | ||
| inst = shared_context.class_inst; | ||
|
|
||
| args = g_new0 (MonoType*, inst->type_argc); |
There was a problem hiding this comment.
Is the memory being deallocated correctly?
There was a problem hiding this comment.
No, it is not. I would suggest deallocating it after
runtime/src/mono/mono/metadata/metadata.c
Line 3399 in 175dae9
^ @vargaz
There was a problem hiding this comment.
I can be freed, but the aot compiler is already leaking memory in a number of places, so its not that important.
…d indentation Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
|
Current failures are known and seem unrelated: |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Remaining failures are known and unrelated. |
Signed-off-by: Vlad - Alexandru Ionescu <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Adding AOT wrappers for delegate invoke virtual.
Contributes to #83329.