Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert JIT/Performance to a merged test group #85851

Merged
merged 6 commits into from
May 12, 2023

Conversation

markples
Copy link
Member

@markples markples commented May 5, 2023

See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way and paying more attention to manual changes.

  • Does anything special need to be done for this directory?
  • outerloop, extra-platforms, gcstress

@markples markples self-assigned this May 5, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 5, 2023
@markples markples added test-enhancement Improvements of test source code area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels May 5, 2023
@ghost
Copy link

ghost commented May 5, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

See https://github.com/markples/utils/tree/for-PR-dotnet-runtime-85847-others for ILTransform tool. As usual, I recommend viewing the commit list since it partitions the changes in a more readable way.

Author: markples
Assignees: markples
Labels:

test-enhancement, area-CodeGen-coreclr

Milestone: -

@markples
Copy link
Member Author

markples commented May 6, 2023

/azp run runtime-coreclr outerloop, runtime-extra-platforms, runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@markples
Copy link
Member Author

This is ready @trylek @dotnet/jit-contrib with the question of whether anything special needs to be done for these performance tests (which seem to be a mirror of the actual performance tests used for correctness testing).

Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me but I must admit I don't have too much of a context on the perf side of these tests.

@BruceForstall
Copy link
Member

It's useful to keep these tests' source code as close to equivalent to the dotnet/performance repo versions as possible -- at least in the core algorithm part.

@markples
Copy link
Member Author

Thank you for all of the quick reviews @trylek!

@markples
Copy link
Member Author

@BruceForstall Thanks for the comment. These diffs are at the "Main" level, not in the core code. I tried to diff the directories, and that part is already different ([Benchmark] vs not) as well as typo fixes, etc., so I think that this is fine.

@markples markples merged commit a8947cc into dotnet:main May 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants