[mono] Avoid an assert if the class name table is too large. #85952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
cc @radical |
vargaz
force-pushed
the
aot-class-name-table
branch
from
7786b0c
to
d289d08
Compare
lambdageek
reviewed
May 10, 2023
| @@ -11646,11 +11646,15 @@ emit_class_name_table (MonoAotCompile *acfg) | |||
| name_p = name_buf = (guint8 *)g_malloc0 (name_buf_size); | |||
| #endif | |||
|
|
|||
| guint table_len = table->len; | |||
| if (table_size > 65000 || table->len > 65000) { | |||
There was a problem hiding this comment.
Why 65000? (As opposed to 65534 or something)
Do we know how much over the limit the microsoft graph API is? I guess metadata tokens are effectively 24 bits right? so there could be as many as 2^24-1 classes in that assembly?
There was a problem hiding this comment.
I mean it's kind of too bad that the largest assembly is the one that gets penalized by not having fast name lookup
There was a problem hiding this comment.
65000 is used to avoid having to think about off by one errors. The assembly has about 40k classes, maybe linking is turned off for it.
lambdageek
approved these changes
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85917.